Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30004: in regex-howto, improve example on grouping #4443

Merged
merged 3 commits into from
Nov 25, 2017
Merged

bpo-30004: in regex-howto, improve example on grouping #4443

merged 3 commits into from
Nov 25, 2017

Conversation

mandeep
Copy link
Contributor

@mandeep mandeep commented Nov 17, 2017 •
edited
Loading

@mandeep
Copy link
Contributor Author

mandeep commented Nov 18, 2017

@serhiy-storchaka I've refactored the other regular expressions. Let me know if you want me to squash the latest commit with the one before it.

@Mariatta Mariatta merged commit 610e5af into python:master Nov 25, 2017
@miss-islington
Copy link
Contributor

Thanks @mandeep for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2017
@mandeep @miss-islington
bpo-30004: Fix the code example of using group in Regex Howto Docs (p…
df138dd 
…ythonGH-4443)

The provided code example was supposed to find repeated words, however it returned false results.
(cherry picked from commit 610e5af)
@bedevere-bot
Copy link

GH-4554 is a backport of this pull request to the 3.6 branch.

@Mariatta
Copy link
Member

Thanks!

@bedevere-bot
Copy link

GH-4555 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2017
@mandeep @miss-islington
bpo-30004: Fix the code example of using group in Regex Howto Docs (p…
80d8a30 
…ythonGH-4443)

The provided code example was supposed to find repeated words, however it returned false results.
(cherry picked from commit 610e5af)
Mariatta pushed a commit that referenced this pull request Nov 25, 2017
@miss-islington @Mariatta
bpo-30004: Fix the code example of using group in Regex Howto Docs (G…
c02037d 
…H-4443) (GH-4555)

The provided code example was supposed to find repeated words, however it returned false results.
(cherry picked from commit 610e5af)
Mariatta pushed a commit that referenced this pull request Nov 25, 2017
@miss-islington @Mariatta
bpo-30004: Fix the code example of using group in Regex Howto Docs (G…
3e60747 
…H-4443) (GH-4554)

The provided code example was supposed to find repeated words, however it returned false results.
(cherry picked from commit 610e5af)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Dec 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mandeep @miss-islington @bedevere-bot @Mariatta @serhiy-storchaka @the-knights-who-say-ni