Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32023: Disallow genexprs without parenthesis in class definitions. #4400

Merged
merged 2 commits into from
Nov 15, 2017
Merged

bpo-32023: Disallow genexprs without parenthesis in class definitions. #4400

merged 2 commits into from
Nov 15, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 15, 2017 •
edited
Loading

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Nov 15, 2017
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 15, 2017
Merged
@ncoghlan
Copy link
Contributor

This PR should reference https://bugs.python.org/issue32023 now

@serhiy-storchaka
Copy link
Member Author

But all discussion is in bpo-32012 and #4382.

@serhiy-storchaka serhiy-storchaka changed the title bpo-32012: Disallow genexprs without parenthesis in class definitions. bpo-32023: Disallow genexprs without parenthesis in class definitions. Nov 15, 2017
ncoghlan
ncoghlan approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks for tolerating my quibbles about clear traceability of the two changes :)

@serhiy-storchaka serhiy-storchaka merged commit ddbce13 into python:master Nov 15, 2017
@serhiy-storchaka serhiy-storchaka deleted the classdef-genexpr branch November 15, 2017 15:39
jimmylai added a commit to jimmylai/cpython that referenced this pull request Nov 17, 2017
@jimmylai
Merge branch 'master' of https://github.com/python/cpython
d914928 
* 'master' of https://github.com/python/cpython: (550 commits)
  bpo-31867: Remove duplicates in default mimetypes. (python#4388)
  tokenizer: Remove unused tabs options (python#4422)
  bpo-31691: Specify where to find build instructions for the Windows installer (python#4426)
  Fix typo in atexit documentation. (pythonGH-4419)
  bpo-31702: Allow to specify rounds for SHA-2 hashing in crypt.mksalt(). (python#4110)
  bpo-32043: New "developer mode": "-X dev" option (python#4413)
  bpo-30349: Raise FutureWarning for nested sets and set operations (python#1553)
  bpo-32037: Use the INT opcode for 32-bit integers in protocol 0 pickles. (python#4407)
  bpo-30143: 2to3 now generates a code that uses abstract collection classes (python#1262)
  bpo-32030: Enhance Py_Main() (python#4412)
  bpo-32030: Split Py_Main() into subfunctions (python#4399)
  bpo-32034: Make IncompleteReadError & LimitOverrunError pickleable python#4409
  bpo-32025: Add time.thread_time() (python#4410)
  bpo-32018: Fix inspect.signature repr to follow PEP 8 (python#4408)
  bpo-30399: Get rid of trailing comma in the repr of BaseException. (python#1650)
  bpo-30950: Convert round() to Argument Clinic. (python#2740)
  bpo-32011: Revert "Issue python#15480: Remove the deprecated and unused TYPE_INT64 code from marshal." (python#4381)
  bpo-32023: Disallow genexprs without parenthesis in class definitions. (python#4400)
  bpo-31949: Fixed several issues in printing tracebacks (PyTraceBack_Print()). (python#4289)
  bpo-32032: Test both implementations of module-level pickle API. (python#4401)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @ncoghlan @the-knights-who-say-ni @bedevere-bot