bpo-31338: Mention that Py_UNREACHABLE was added in 3.7 #4337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro was added for bpo-31338 in commit b2e5794
Merged
serhiy-storchaka
approved these changes
Nov 8, 2017
serhiy-storchaka
changed the title
|
Thanks @encukou. |
vstinner
reviewed
Nov 8, 2017
| @@ -106,6 +106,8 @@ complete listing. | |||
| all possible values are covered in ``case`` statements. Use this in places | |||
| where you might be tempted to put an ``assert(0)`` or ``abort()`` call. | |||
|
|
|||
| .. versionadded:: 3.7 | |||
|
|
|||
| .. c:macro:: Py_ABS(x) | |||
|
|
|||
| Return the absolute value of ``x``. | |||
There was a problem hiding this comment.
While you add versionadded, you may also document:
- Py_MIN, Py_MAX, Py_ABS: Python 3.3
- Py_STRINGIFY: Python 3.4
- Py_MEMBER_SIZE: Python 3.6
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
The macro was added for bpo-31338 in commit b2e5794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro was added for bpo-31338 in commit b2e5794.
I think this note is trivial enough to not need its own issue or NEWS entry.
https://bugs.python.org/issue31338