Skip to content

bpo-31957: Fixes version detection. #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2017
Merged

bpo-31957: Fixes version detection. #4298

merged 2 commits into from
Nov 6, 2017

Conversation

zooba
Copy link
Member

@zooba zooba commented Nov 6, 2017

@zooba zooba added needs backport to 3.6 OS-windows type-bug An unexpected behavior, bug, or error labels Nov 6, 2017
@zooba zooba requested a review from a team as a code owner November 6, 2017 19:54
@zooba zooba changed the title Fixes version detection. bpo-31957: Fixes version detection. Nov 6, 2017
@zooba zooba closed this Nov 6, 2017
@zooba zooba reopened this Nov 6, 2017
@zooba
Copy link
Member Author

zooba commented Nov 6, 2017

Looks like AppVeyor is having a bad day...

@zooba zooba closed this Nov 6, 2017
@zooba zooba reopened this Nov 6, 2017
@zooba
Copy link
Member Author

zooba commented Nov 6, 2017

AppVeyor is fine, but failed to update the status. If you log in directly you can see the successful build.

@zooba zooba merged commit 30f4fa4 into python:master Nov 6, 2017
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2017
@bedevere-bot
Copy link

GH-4300 is a backport of this pull request to the 3.6 branch.

@zooba zooba deleted the bpo31957 branch November 6, 2017 20:52
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
isuruf added a commit to isuruf/cpython that referenced this pull request Mar 19, 2019
isuruf added a commit to isuruf/cpython that referenced this pull request Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants