gh-75646: allow _PyType_Lookup() to raise exceptions #3616

scoder · 2017-09-16T11:55:00Z

This is based off #3279, the first commits are the same, because they touch the same code. FIrst new commit is 6c61028, right after the merge of "master". 6c61028 is a related bug fix, an unchecked error case.

Probably needs new tests that exercise the error conditions.

https://bugs.python.org/issue31465

Issue: Allow _PyType_Lookup() to raise exceptions #75646

…hained name lookups in _PyType_Lookup().

…m update_one_slot().

…r ceases to be a valid base type, there'll probably be larger code sections to change than this one.

…common in Python 3 now. Also make the step from "return NULL" error handling to "goto error" reference cleanup explicit.

Distinguish between "error" and "error with exception" cases in _PyType_LookupUncached(). Fix a reference leak of "mro" on lookup errors. Resolves issues found by Serhiy Storchaka.

…isting) API names. Suggested by Serhiy Storchaka.

…l PyObject_GetItem() for them.

…e-calculation if the mapping is not exactly a dict.

…ential re-calculation if the mapping is not exactly a dict." This reverts commit 1d52082.

… and call PyObject_GetItem() for them." This reverts commit 09e716a.

…g lookup exceptions, just like "_PyType_Lookup()" did previously.

…ce eating lookup exceptions, just like "_PyType_Lookup()" did previously." This reverts commit 4efde8e.

…) from functions that swallow live exceptions.

…rywhere else).

… handle them in the code that calls these functions. The one non-exception error case during lookup ("no MRO") is not handled since it is unlikely and not user visible. Note that this changes the signature of both functions, but they are clearly not public functions. Currently leads to crashes due to NULL returns without exceptions set. Needs investigation.

markshannon · 2018-07-29T11:41:59Z

Two minor points.
I would prefer a new function, rather than modifying the signature of _PyType_Lookup.
Also, I think it is the conventional to return error codes directly and objects via the pointer, not the other way around. So int _PyType_Lookup(type, name, *result) not PyObject *_PyType_Lookup(type, name, *error)

github-actions · 2022-02-22T00:08:32Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2022-08-31T00:15:55Z

This PR is stale because it has been open for 30 days with no activity.

iritkatriel

This has merge conflicts now.

bedevere-bot · 2022-11-25T11:12:37Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

github-actions · 2022-12-26T00:11:16Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2023-03-26T00:11:38Z

This PR is stale because it has been open for 30 days with no activity.

furkanonder · 2023-05-11T15:05:34Z

@scoder Could you resolve the conflicts?

github-actions · 2023-06-11T00:12:02Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2023-07-15T00:12:16Z

This PR is stale because it has been open for 30 days with no activity.

Stefan Behnel added 23 commits September 4, 2017 13:27

Speed up type creation, which is highly dominated by slow dict lookups.

0a865c9

Update comment after changing the function call that it refers to.

c4779e3

Ignore any errors (however unlikely) that may happen during the mro c…

ff2ea63

…hained name lookups in _PyType_Lookup().

Extract non-caching code from _PyType_Lookup() to use it directly fro…

76b1986

…m update_one_slot().

Avoid some useless overhead for the no-basetype case. If "object" eve…

6f98485

…r ceases to be a valid base type, there'll probably be larger code sections to change than this one.

Add comment.

d9b726e

Avoid uselessly searching empty bases for a metaclass. This is quite …

be15255

…common in Python 3 now. Also make the step from "return NULL" error handling to "goto error" reference cleanup explicit.

Avoid unsafe handling of borrowed "mro" reference during hash() call.

0736226

Distinguish between "error" and "error with exception" cases in _PyType_LookupUncached(). Fix a reference leak of "mro" on lookup errors. Resolves issues found by Serhiy Storchaka.

Clean up code and formatting a little.

8bc783f

Add braces for code style reasons.

66648dd

Give internal helper function a local name that does not resemble (ex…

85fb3ae

…isting) API names. Suggested by Serhiy Storchaka.

Allow non-dict types for the class dict when looking up names and cal…

09e716a

…l PyObject_GetItem() for them.

Lazily calculate name hash in find_name_in_mro() to avoid potential r…

1d52082

…e-calculation if the mapping is not exactly a dict.

Revert "Lazily calculate name hash in find_name_in_mro() to avoid pot…

f09bfd3

…ential re-calculation if the mapping is not exactly a dict." This reverts commit 1d52082.

Revert "Allow non-dict types for the class dict when looking up names…

824d7cb

… and call PyObject_GetItem() for them." This reverts commit 09e716a.

add news entry for faster class creation

5184191

Change nice interface of "find_name_in_mro()" to evil interface eatin…

4efde8e

…g lookup exceptions, just like "_PyType_Lookup()" did previously.

Mention amount of speedup in News entry.

f5bce2a

Revert "Change nice interface of "find_name_in_mro()" to evil interfa…

02bfef0

…ce eating lookup exceptions, just like "_PyType_Lookup()" did previously." This reverts commit 4efde8e.

Guard against external live exceptions when calling find_name_in_mro(…

2497858

…) from functions that swallow live exceptions.

Merge branch 'master' into _pt_lookup_exc

c56990d

Propagate exception when _PyObject_LookupSpecial() fails (as done eve…

6c61028

…rywhere else).

scoder requested a review from rhettinger as a code owner September 16, 2017 11:55

the-knights-who-say-ni added the CLA signed label Sep 16, 2017

bedevere-bot added the awaiting review label Sep 16, 2017

scoder mentioned this pull request Sep 18, 2017

bpo-31336: Speed up type creation, which is highly dominated by slow dict lookups. #3279

Merged

Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017

github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 22, 2022

This comment was marked as outdated.

Sign in to view

rhettinger approved these changes May 1, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels May 1, 2022

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 31, 2022

iritkatriel requested changes Nov 25, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting merge labels Nov 25, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Nov 26, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 26, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 23, 2023

github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 26, 2023

github-actions bot removed the stale Stale PR or inactive for long period of time. label May 12, 2023

github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 11, 2023

erlend-aasland changed the title ~~bpo-31465: allow _PyType_Lookup() to raise exceptions~~ gh-75646: allow _PyType_Lookup() to raise exceptions Jun 14, 2023

github-actions bot removed the stale Stale PR or inactive for long period of time. label Jun 15, 2023

github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 15, 2023

scoder mentioned this pull request Oct 22, 2023

Allow _PyType_Lookup() to raise exceptions #75646

Open

AlexWaygood mentioned this pull request Nov 27, 2023

All exceptions are swallowed when looking up __set_name__ on an object in a class namespace during construction of that class #112453

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-75646: allow _PyType_Lookup() to raise exceptions #3616

gh-75646: allow _PyType_Lookup() to raise exceptions #3616

Uh oh!

scoder commented Sep 16, 2017 •

edited by bedevere-bot

Loading

Uh oh!

markshannon commented Jul 29, 2018

Uh oh!

github-actions bot commented Feb 22, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Aug 31, 2022

Uh oh!

iritkatriel left a comment

Uh oh!

bedevere-bot commented Nov 25, 2022

Uh oh!

github-actions bot commented Dec 26, 2022

Uh oh!

github-actions bot commented Mar 26, 2023

Uh oh!

furkanonder commented May 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

github-actions bot commented Jul 15, 2023

Uh oh!

Uh oh!

Uh oh!

gh-75646: allow _PyType_Lookup() to raise exceptions #3616

Are you sure you want to change the base?

gh-75646: allow _PyType_Lookup() to raise exceptions #3616

Uh oh!

Conversation

scoder commented Sep 16, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markshannon commented Jul 29, 2018

Uh oh!

github-actions bot commented Feb 22, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Aug 31, 2022

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 25, 2022

Uh oh!

github-actions bot commented Dec 26, 2022

Uh oh!

github-actions bot commented Mar 26, 2023

Uh oh!

furkanonder commented May 11, 2023

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

github-actions bot commented Jul 15, 2023

Uh oh!

Uh oh!

scoder commented Sep 16, 2017 •

edited by bedevere-bot

Loading