-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31370: Remove support for threads-less builds #3385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! i skimmed over everything, it looks good. lots of mechanical changes. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the "#define WITH_THREAD 1" for backward compatibily. Maybe in pyport.h?
LGTM if you keep the define, but I would like to see a review of another core dev like @ericsnowcurrently.
See https://bugs.python.org/issue27961#msg276881 and commit a251fb0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test_email change looks fine :)
I think this needs a mention in What's New as well.
Ok, done. |
Ok, done. |
Thanks, I merged your change ;-) |
Ignore below; forgot to copy Modules/Setup.dist to Modules/Setup Anyone else getting this error when trying to build Python on OS X after the merge?
It seems that Full part of the make process:
|
Resolve conflicts: a6a4dc8 bpo-31370: Remove support for threads-less builds (python#3385)
* Remove Setup.config * Always define WITH_THREAD for compatibility.
python/cpython#109462 removed `logging._acquireLock`. Fortunately, python/cpython#3385 simplified lock creation so that `with logging._lock:` is sufficient; that PR made it into Python 3.7, which is already pastescript's minimum Python requirement.
python/cpython#109462 removed `logging._acquireLock`. Fortunately, python/cpython#3385 simplified lock creation so that `with logging._lock:` is sufficient; that PR made it into Python 3.7, which is already pastescript's minimum Python requirement.
Aquire the logging lock using the underlying _lock object from the logging module. As of python/cpython#3385, included in Python 3.7, this object an instance of threading.RLock whose use as a context manager with release being called when the block exits, see https://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement
* aquire logging lock using _lock context manager Aquire the logging lock using the underlying _lock object from the logging module. As of python/cpython#3385, included in Python 3.7, this object an instance of threading.RLock whose use as a context manager with release being called when the block exits, see https://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement * mark conda.common.io._logger_lock for deprecation * add news * Update news/14584-use-logging-lock * Apply suggestions from code review --------- Co-authored-by: Daniel Holth <dholth@anaconda.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
https://bugs.python.org/issue31370