Skip to content

bpo-30940: specify what happens if ndigits is None or omitted #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

elenaoat
Copy link
Contributor

@elenaoat elenaoat commented Aug 31, 2017

I've added the latest changes that were mentioned in the bug tracker.

https://bugs.python.org/issue30940

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!


For a general Python object ``number``, ``round(number, ndigits)`` delegates to
``number.__round__(ndigits)``.
For a general Python object ``number``, ``round`` delegates to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than lose information with this edit, I would prefer to make it more precise, "For a general Python object, round(number) or round(number, None) delegates to number.__round__(), and round(number, ndigits) delegates to number.__round__(ndigits)."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the text accordingly.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ned-deily
Copy link
Member

Based on more recent discussion on the tracker, it looks these proposed changes have now been addressed by other PRs, primarily #6342 and #2740. Thanks for your contribution @elenaoat!

@ned-deily ned-deily closed this Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants