Skip to content

bpo-47168: List feature macros in the stable ABI manifest, improve tests #32415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 28, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 8, 2022

This depends on #32414. The refactoring+tests should go in a separate commit.

I plan some more deduplication, and use the name “feature macro” rather than ifdef everywhere, after converting stable-abi.txt to TOML so it's easier to work with.

https://bugs.python.org/issue47168

@encukou encukou requested a review from a team as a code owner April 8, 2022 13:24
@encukou encukou marked this pull request as draft April 8, 2022 13:25
@encukou encukou marked this pull request as ready for review April 22, 2022 11:23
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 896f4d0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2022
@encukou encukou merged commit 6dcbc08 into python:main Apr 28, 2022
@encukou encukou deleted the stable-ifdef branch April 29, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants