bpo-47076: fix test_asyncio: test_get_cancelled()#32020
Closed
kumaraditya303 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@sweeneyde Can you add Test with buildbots label ? |
sweeneyde
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 0eb0db7 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Contributor
Author
|
cc @vstinner |
vstinner
reviewed
Mar 21, 2022
|
|
||
| async def queue_get(): | ||
| started.set() | ||
| return await asyncio.wait_for(q.get(), 0.051) |
Member
There was a problem hiding this comment.
is the wait_for() call still useful?
Contributor
There was a problem hiding this comment.
The whole test is redundant IMHO.
Please take a look at #32040 for the alternative fix that affects more problematic tests.
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue47076