[3.10] Corrections to format precision description. (GH-31291) #31320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `precision` field is a decimal integer
* clarify that stated limitations are on presentation type
rather than input value type. Especially misleading is
"precision is not allowed for integer values", since integer
value input to a format like `.1f` is fine.
* regarding max field size, replace "non-number" with "string",
which is the only non-numeric presentation type
Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit 1d6ce67)
Co-authored-by: John Belmonte <john@neggie.net>
|
@belm0: Status check is done, and it's a failure ❌ . |
|
@belm0: Status check is done, and it's a failure ❌ . |
ericvsmith
approved these changes
Feb 14, 2022
|
@belm0: Status check is done, and it's a success ✅ . |
|
@belm0: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precisionfield is a decimal integerrather than input value type. Especially misleading is
"precision is not allowed for integer values", since integer
value input to a format like
.1fis fine.which is the only non-numeric presentation type
Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit 1d6ce67)
Co-authored-by: John Belmonte john@neggie.net
Automerge-Triggered-By: GH:ericvsmith