bpo-46648: move test_issue16464 to urllib2_localnet
#31186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
approved these changes
Feb 7, 2022
gpshead
added
needs backport to 3.9
raghavthind2005
approved these changes
Feb 7, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-31189 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
PR merged, thanks. I rewrote the commit title/description. |
|
GH-31190 is a backport of this pull request to the 3.9 branch. |
|
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
|
OK, nevermind, I'll use GH-31173 instead. |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the flaky test to
test_urllib2_localnetas @gpshead suggested.I hope that it will now be reliable 🎉
https://bugs.python.org/issue46648