Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 18, 2022

Refs #30641
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

I am going to mark this as "needs backport" to 3.9 and 3.10, because this is a bugfix.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.10

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.9

@serhiy-storchaka
Copy link
Member

@sobolevn, do you mind to create backports manually?

@sobolevn
Copy link
Member Author

Sure, will do today 👍

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
…honGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 19, 2022
@bedevere-bot
Copy link

GH-30699 is a backport of this pull request to the 3.10 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
…onGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-30700 is a backport of this pull request to the 3.9 branch.

@sobolevn
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants