Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-10850: Fix multiprocessing.managers.Server classvar #30086

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bpo-10850: Fix multiprocessing.managers.Server classvar #30086

wants to merge 3 commits into from

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Dec 13, 2021 •
edited
Loading

The classvar is defined but not used.

No need for NEWS, this is mostly internal atm.

https://bugs.python.org/issue10850

nanjekyejoannah
nanjekyejoannah reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am inclined to think, we document this change in a news entry, if consensus is reached especially for the change. Am not giving consensus some other core devs with expertise can review the BPO and this PR,

@bharel
Copy link
Contributor Author

bharel commented Dec 20, 2021

Am inclined to think, we document this change in a news entry, if consensus is reached especially for the change. Am not giving consensus some other core devs with expertise can review the BPO and this PR,

It is completely internal and not facing the users, I doubt we need a news entry.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 20, 2022
@MaxwellDupre
Copy link
Contributor

Can you add a use/test case for this as its difficult to understand (undocumented) feature(s). Also, why you need to return _Server?

@chrysn chrysn mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time. topic-multiprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bharel @MaxwellDupre @nanjekyejoannah @vstinner @the-knights-who-say-ni @ezio-melotti @bedevere-bot