Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (GH-29642) #29642

Merged
merged 1 commit into from
Nov 19, 2021
Merged

bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (GH-29642) #29642

merged 1 commit into from
Nov 19, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 19, 2021 •
edited by bedevere-bot
Loading

@tiran
Copy link
Member Author

tiran commented Nov 19, 2021 

$ ./configure -C --without-builtin-hashlib-hashes
$ make clean
$ make
...
The following modules found by detect_modules() in setup.py have not
been built, they are *disabled* by configure:
_blake2               _md5                  _sha1              
_sha256               _sha3                 _sha512            
...
$ ./python -c "import _sha1"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named '_sha1'

erlend-aasland
erlend-aasland reviewed Nov 19, 2021
View reviewed changes
Modules/Setup.stdlib.in
Comment on lines +41 to +46
@MODULE__MD5_TRUE@_md5 md5module.c
@MODULE__SHA1_TRUE@_sha1 sha1module.c
@MODULE__SHA256_TRUE@_sha256 sha256module.c
@MODULE__SHA512_TRUE@_sha512 sha512module.c
@MODULE__SHA3_TRUE@_sha3 _sha3/sha3module.c
@MODULE__BLAKE2_TRUE@_blake2 _blake2/blake2module.c _blake2/blake2b_impl.c _blake2/blake2s_impl.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the "old" entries in Modules/Setup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules/Setup.stdlib is not used yet. I like to get all modules into the new setup file and then we can decide what do do about the old setup file.

@tiran tiran changed the title bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (GH-29642) Nov 19, 2021
@tiran tiran merged commit c8c21bd into python:main Nov 19, 2021
@tiran tiran deleted the bpo-45847-hashes branch November 19, 2021 19:20
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45847: Port builtin hashlib extensions to PY_STDLIB_MOD (pythonGH…
e35adf6 
…-29642)
@tiran tiran mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot