bpo-45837: Properly deprecate turtle.RawTurtle.settiltangle #29618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turtle's
settiltangle
was deprecated in Python 3.1, according to docs:And the reason:
However, in docstrings,
tiltangle
was accidentally commented as deprecated:Neither
tiltangle
norsettiltangle
raiseDeprecationWarning
s.So let's:
tiltangle
's docstring to say it's not really deprecatedsettiltangle
's docstring to say it's deprecatedDeprecationWarning
tosettiltangle
self.tiltangle
instead ofself.settiltangle
BPO references:
2009 https://bugs.python.org/issue5923 - when
settiltangle
was originally deprecated, with rationale.2010 https://bugs.python.org/issue7888 - the deprecation mixup was discovered and apparently corrected in py3k and release31-maint. I've not done the SCM archaeology to discover why this didn't make it through!
2020 https://bugs.python.org/issue41165 - both mentioned as deprecated, discrepancy not noted.
https://bugs.python.org/issue45837