Skip to content

bpo-45573: Use Makefile's dependencies in setup.py (GH-29559) #29559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 14, 2021

setup.py now reads MODULE_{name}_DEPS from Makefile to populate
an extension's depends field.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45573

setup.py now reads ``MODULE_{name}_DEPS`` from ``Makefile`` to populate
an extension's depends field.

Signed-off-by: Christian Heimes <christian@python.org>
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@tiran tiran changed the title bpo-45573: Use Makefile's dependencies in setup.py bpo-45573: Use Makefile's dependencies in setup.py (GH-29559) Nov 14, 2021
@tiran tiran merged commit c399786 into python:main Nov 14, 2021
@tiran tiran deleted the bpo-45573-deps branch November 14, 2021 19:55
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit c399786.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/1196) and take a look at the build logs.
  4. Check if the failure is related to this commit (c399786) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/1196

Failed tests:

  • test_signal

Failed subtests:

  • test_stress_modifying_handlers - test.test_signal.StressTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

  • test_tools: 4 min 15 sec
  • test_concurrent_futures: 3 min 8 sec
  • test_multiprocessing_spawn: 2 min 13 sec
  • test_shelve: 1 min 50 sec
  • test_peg_generator: 1 min 44 sec
  • test_mailbox: 1 min 35 sec
  • test_tokenize: 1 min 27 sec
  • test_multiprocessing_forkserver: 1 min 25 sec
  • test_multiprocessing_fork: 1 min 14 sec
  • test_largefile: 1 min 14 sec

1 test failed:
test_signal

20 tests skipped:
test_devpoll test_epoll test_gdb test_idle test_ioctl test_kqueue
test_msilib test_smtpnet test_ssl test_startfile test_tcl test_tix
test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_signal

Total duration: 23 min 4 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_198512f4'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_37049669'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_signal.py", line 1334, in test_stress_modifying_handlers
    self.assertGreater(num_received_signals, 0)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 not greater than 0


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_1fd3d4e7'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants