-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291 #29416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix confirmed on the Windows 8.1 refleak buildbot:
Build link: https://buildbot.python.org/all/#/builders/443/builds/9 |
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry @ambv, I had trouble checking out the |
GH-29420 is a backport of this pull request to the 3.9 branch. |
… (pythonGH-29416) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
… (pythonGH-29416) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
The closure in
cb_test
was the root cause of the refleak, to address it we're taking the callback handle and deleting it when we don't need it anymore. Additionally, other tests explicitly destroyOptionMenu
objects to avoid issues with reference cycles.Before the change
After the change
https://bugs.python.org/issue45160