bpo-45020: Make "make all" output less noisy. #28554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Sep 24, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Sorry, this feels too fragile. I prefer one line per generated .h file over this.
Member
Author
|
FYI, I'm de-prioritizing (tabling) this change. |
gvanrossum
reviewed
Sep 27, 2021
|
|
||
| Python/frozen_modules/__hello__.h: Programs/_freeze_module Lib/__hello__.py | ||
| Programs/_freeze_module __hello__ $(srcdir)/Lib/__hello__.py $(srcdir)/Python/frozen_modules/__hello__.h | ||
| $(FROZEN_DATA)/%.h: Programs/_freeze_module |
Member
There was a problem hiding this comment.
FWIW, the commands in the block below this line give me the creeps (== I've never seen such make syntax before :-).
But perhaps we can define a pattern rule that tells how to generate a frozen .h file from a Lib .py file? That won't change the output volume, but it will simplify the Makefile.
Member
|
Closing so it doesn't show as open in the bpo issue. |
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus here is on the output from generating frozen modules. Now we only print 3 lines when generating them. This is especially important as we freeze more modules.
https://bugs.python.org/issue45020