bpo-40503: Check in <prefix>/share/zoneinfo for zoneinfo files on windows #28495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
zooba
reviewed
Feb 26, 2024
| @@ -489,7 +489,11 @@ def _init_non_posix(vars): | |||
| vars['EXE'] = '.exe' | |||
| vars['VERSION'] = _PY_VERSION_SHORT_NO_DOT | |||
| vars['BINDIR'] = os.path.dirname(_safe_realpath(sys.executable)) | |||
| vars['TZPATH'] = '' | |||
| check_tzpath = os.path.join(vars['prefix'], 'share', 'zoneinfo') | |||
There was a problem hiding this comment.
Suggested change
| check_tzpath = os.path.join(vars['prefix'], 'share', 'zoneinfo') | |
| # No standard path exists on Windows for this, but we'll check | |
| # whether someone is imitating a POSIX-like layout | |
| check_tzpath = os.path.join(vars['prefix'], 'share', 'zoneinfo') |
|
LGTM, though I'd like to have a comment at least acknowledging that this path is one guess, and not in any way a standard or expectation. There's also a merge conflict of some kind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dows
This is a relocatable path and conda uses this path for zoneinfo files on windows.
https://bugs.python.org/issue40503