Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45132 Remove deprecated __getitem__ methods #28225

Merged
merged 4 commits into from
Sep 8, 2021
Merged

bpo-45132 Remove deprecated __getitem__ methods #28225

merged 4 commits into from
Sep 8, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 7, 2021 •
edited by bedevere-bot
Loading

Remove deprecated __getitem__ methods of xml.dom.pulldom.DOMEventStream, wsgiref.util.FileWrapper and fileinput.FileInput, deprecated since Python 3.9.

https://bugs.python.org/issue45132

@hugovk
bpo-45132 Remove deprecated __getitem__ methods
ccf7990 
Remove deprecated __getitem__ methods of xml.dom.pulldom.DOMEventStream,
wsgiref.util.FileWrapper and fileinput.FileInput, deprecated since Python 3.9.
serhiy-storchaka
serhiy-storchaka reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have some documentation nitpicks.

hugovk and others added 2 commits September 8, 2021 10:50
@hugovk @serhiy-storchaka
bpo-45132 Update documentation
72983dc 
`deprecated-removed` is only used for future planned removing. After removing it is just `versionchanged`.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hugovk
bpo-45132 Update docs
34f42d9 
Insert "In addition it is :term:`iterable` and has a ..."

deprecated-removed is only used for future planned removing.
After removing it is just versionchanged.
@hugovk
Copy link
Member Author

hugovk commented Sep 8, 2021

@serhiy-storchaka Thanks for the review, updated! Let me know if I should squash the commits or anything like that.

Thanks also for the guidance about deprecated-removed / versionchanged. I'd checked deprecated-removed in the devguide but it didn't say it's only for pre-removal; I'll make a PR to update the devguide.

https://devguide.python.org/documenting/?highlight=deprecated-removed#paragraph-level-markup

serhiy-storchaka
serhiy-storchaka reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing deprecated features we remove deprecated directives.

@hugovk
Copy link
Member Author

hugovk commented Sep 8, 2021

After removing deprecated features we remove deprecated directives.

Ah right, so should I do this too?

-   .. deprecated:: 3.8
+   .. versionchanged:: 3.8
      Support for :meth:`__getitem__` method is deprecated.

@serhiy-storchaka
Copy link
Member

Replace deprecated with versionchanged, is deprecated with has been removed (or something like), and move the directive down if necessary. Since you already added versionchanged directives, just remove corresponding deprecated directives. They are not of interest to users of future Python versions.

serhiy-storchaka
serhiy-storchaka approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Sep 8, 2021
@serhiy-storchaka serhiy-storchaka merged commit d003a5b into python:main Sep 8, 2021
@hugovk hugovk deleted the rm-deprecated-__getitem__ branch September 8, 2021 10:13
@serhiy-storchaka
Copy link
Member

After reading the devguide I am no longer sure about deprecated-removed. Maybe I always used it incorrectly. Or its semantic was changed with time. It needs additional discussion.

@serhiy-storchaka
Copy link
Member

Opened a thread on Python-Dev: https://mail.python.org/archives/list/python-dev@python.org/thread/SWBM2N4EFPVQFP4TX6Q33L5OK2WPBFRU/ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot