Skip to content

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) #28217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2021
Merged

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) #28217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573b8ee
[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205)
tiran Sep 7, 2021
a883f09
Merge remote-tracking branch '3.9' into backport-cc7c680-3.9
ambv Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
strategy:
fail-fast: false
matrix:
openssl_ver: [1.0.2u, 1.1.0l, 1.1.1l, 3.0.0-beta1]
openssl_ver: [1.0.2u, 1.1.0l, 1.1.1l, 3.0.0]
env:
OPENSSL_VER: ${{ matrix.openssl_ver }}
MULTISSL_DIR: ${{ github.workspace }}/multissl
Expand Down
6 changes: 5 additions & 1 deletion Tools/ssl/multissltests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

OPENSSL_RECENT_VERSIONS = [
"1.1.1l",
"3.0.0-beta1"
"3.0.0"
]

LIBRESSL_OLD_VERSIONS = [
Expand Down Expand Up @@ -410,6 +410,10 @@ def _post_install_300(self):
["make", "-j1", "install_ssldirs", "install_fips"],
cwd=self.build_dir
)
if not os.path.isdir(self.lib_dir):
# 3.0.0-beta2 uses lib64 on 64 bit platforms
lib64 = self.lib_dir + "64"
os.symlink(lib64, self.lib_dir)
Comment on lines +413 to +416
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this change causes all SSL tests to fail on 3.9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems unlikely. The _post_install_300 function is only executed if self.version.startswith("3.0").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have bisected the failing tests in 3.9. Tests are passing in commit for tag v3.9.7. Current 3.9 is failing. The issue was introduced in c967bd5 (GH-28153).

@serhiy-storchaka please take a look

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tiran. Shame on me. I have no idea how could I miss these warnings.

#28236 should fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you didn't notice because the tests were skipped. Additional OpenSSL tests are only executed for some changes:

cpython/.github/workflows/build.yml

Line 53 in c11956a

git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE '(ssl|hashlib|hmac|^.github)' && echo '::set-output name=run_ssl_tests::true' || true


@property
def short_version(self):
Expand Down