[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) #28217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heimes <christian@python.org>. (cherry picked from commit cc7c680) Co-authored-by: Christian Heimes <christian@python.org>
ambv
commented
Sep 7, 2021
Comment on lines
+413
to
+416
| if not os.path.isdir(self.lib_dir): | ||
| # 3.0.0-beta2 uses lib64 on 64 bit platforms | ||
| lib64 = self.lib_dir + "64" | ||
| os.symlink(lib64, self.lib_dir) |
There was a problem hiding this comment.
Seems like this change causes all SSL tests to fail on 3.9?
There was a problem hiding this comment.
That seems unlikely. The _post_install_300 function is only executed if self.version.startswith("3.0").
There was a problem hiding this comment.
I have bisected the failing tests in 3.9. Tests are passing in commit for tag v3.9.7. Current 3.9 is failing. The issue was introduced in c967bd5 (GH-28153).
@serhiy-storchaka please take a look
There was a problem hiding this comment.
I guess you didn't notice because the tests were skipped. Additional OpenSSL tests are only executed for some changes:
cpython/.github/workflows/build.yml
Line 53 in c11956a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org.
(cherry picked from commit cc7c680)
Co-authored-by: Christian Heimes christian@python.org
https://bugs.python.org/issue38820