bpo-42560: tweaks to intro of Tkinter docs- add macOS, drop ActiveState #27835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E-Paine
approved these changes
Aug 21, 2021
| platforms, as well as on Windows systems. (Tk itself is not part of Python; it | ||
| is maintained at ActiveState.) | ||
| the Tcl/Tk GUI toolkit. Both Tk and :mod:`tkinter` are available on most Unix | ||
| platforms, including macOS, as well as on Windows systems. |
There was a problem hiding this comment.
Suggested change
| platforms, including macOS, as well as on Windows systems. | |
| platforms (including macOS) as well as on Windows systems. |
IMO, this flows better with the following "as well as ..."
There was a problem hiding this comment.
Disagree, as you need the comma before "as well as" for the external flow anyway, as you can see on the red part of the diff.
ambv
added
needs backport to 3.9
|
GH-27891 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2021
…te (pythonGH-27835) (cherry picked from commit 141c7a4) Co-authored-by: Mark Roseman <mark@markroseman.com>
|
GH-27892 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2021
…te (pythonGH-27835) (cherry picked from commit 141c7a4) Co-authored-by: Mark Roseman <mark@markroseman.com>
ambv
pushed a commit
that referenced
this pull request
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42560