bpo-43853: Expand test suite for SQLite UDF's by erlend-aasland · Pull Request #27642 · python/cpython

erlend-aasland · 2021-08-06T19:43:17Z

Test that strings that contain embedded NULL characters are passed to UDF's
Consolidate "test param" tests to reduce the amount of boilerplate code
Test more error conditions when building UDF arguments, and returning UDF values
Handle PyFloat_AsDouble() errors

https://bugs.python.org/issue43853

…nctions

erlend-aasland · 2021-08-06T19:46:48Z

FYI: Tests for aggregate functions are already in place (implemented in GH-27588).

@serhiy-storchaka, is the refactor commit acceptable? Code coverage is preserved.

Lib/sqlite3/test/userfunctions.py

serhiy-storchaka · 2021-08-07T14:37:46Z

Ignore my comments about values which cause errors. I covered them in #27654. But please add more test cases for valid values of different types.

Modules/_sqlite/connection.c

Lib/sqlite3/test/userfunctions.py

erlend-aasland · 2021-08-12T11:20:06Z

I've updated the PR. PTAL, @serhiy-storchaka.

erlend-aasland · 2021-09-14T21:46:00Z

~~Marked as draft, as I need to resolve some potential issues created by GH-27884.~~

Resolved: only test arguments passed to UDF's

erlend-aasland · 2021-09-15T08:24:08Z

@serhiy-storchaka, please take a new look.

erlend-aasland · 2022-01-26T15:22:19Z

Go ahead and land it!

I can't; I don't have the commit bit :)

gvanrossum · 2022-01-26T16:25:57Z

What?! I thought you did. You should. Who's mentoring you?

miss-islington · 2022-01-26T16:26:20Z

Thanks @erlend-aasland for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington · 2022-01-26T16:26:24Z

Sorry, @erlend-aasland and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.10

miss-islington · 2022-01-26T16:26:27Z

Sorry @erlend-aasland and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.9

JelleZijlstra · 2022-01-26T16:35:49Z

I can't; I don't have the commit bit :)

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

erlend-aasland · 2022-01-26T17:00:45Z

What?! I thought you did. You should. Who's mentoring you?

First @corona10, now @pablogsal 🙂

(BTW, I'll fix the backports.)

erlend-aasland · 2022-01-26T17:01:50Z

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

I've been around a year or two, IIRC :)

pablogsal · 2022-01-26T17:09:42Z

What?! I thought you did. You should. Who's mentoring you?

We have already offer the promotion a couple of times, we are working on it 😉

(cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot · 2022-01-30T20:00:19Z

GH-31030 is a backport of this pull request to the 3.10 branch.

erlend-aasland · 2022-01-30T20:01:36Z

Backporting to 3.9 from GH-31030.

…1030) * [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642). (cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no> * Fix test_func_return_too_large_int GH-27613 (bpo 44839) was not backported, so exceptions differ between main (3.11) and older versions.

…ythonGH-31030) (cherry picked from commit 3eb3b4f)

) (GH-31586) (cherry picked from commit 3eb3b4f)

…ythonGH-31030) (pythonGH-31586) (cherry picked from commit 3eb3b4f)

Erlend E. Aasland added 2 commits August 6, 2021 21:37

Test that str params with embedded NULL chars are passed to SQLite fu…

1fa7e13

…nctions

Refactor most set param tests

aebc9de

erlend-aasland requested a review from berkerpeksag as a code owner August 6, 2021 19:43

the-knights-who-say-ni added the CLA signed label Aug 6, 2021

bedevere-bot added the awaiting review label Aug 6, 2021

erlend-aasland requested a review from serhiy-storchaka August 6, 2021 19:43

erlend-aasland added the skip news label Aug 6, 2021

erlend-aasland added needs backport to 3.9 needs backport to 3.10 only security fixes labels Aug 6, 2021

serhiy-storchaka reviewed Aug 6, 2021

View reviewed changes

Lib/sqlite3/test/userfunctions.py Show resolved Hide resolved

Lib/sqlite3/test/userfunctions.py Show resolved Hide resolved

Lib/sqlite3/test/userfunctions.py Show resolved Hide resolved

Lib/sqlite3/test/userfunctions.py Outdated Show resolved Hide resolved

expand test suite and check for PyFloat_AsDouble errors

13f2413

This was referenced Aug 7, 2021

gh-89018: Improve documentation of sqlite3 exceptions #27645

Merged

bpo-44859: Improve error handling in sqlite3 and change some errors #27654

Merged

serhiy-storchaka reviewed Aug 8, 2021

View reviewed changes

Erlend E. Aasland added 2 commits August 8, 2021 22:18

Address review: add more tests

3ed9af6

Sync with 'main' bco. pythonGH-27654

476edeb

erlend-aasland requested a review from serhiy-storchaka August 8, 2021 20:21

Erlend E. Aasland added 4 commits August 12, 2021 13:44

Test surrogates and non-ascii chars

05c2f80

Test 63-bit int with non-zero low bits

21022c2

import test.support.gc_collect iso. import gc

0a8ba42

Merge branch 'main' into sqlite-test-udf-str-with-null

9f288f1

erlend-aasland marked this pull request as draft September 14, 2021 21:44

Erlend E. Aasland added 2 commits September 15, 2021 10:15

Make test_func_params more specific

02725cf

Remove unneeded test UDF

5be2810

erlend-aasland marked this pull request as ready for review September 15, 2021 08:23

gvanrossum merged commit 3eb3b4f into python:main Jan 26, 2022

bedevere-bot removed the awaiting core review label Jan 26, 2022

miss-islington assigned gvanrossum Jan 26, 2022

erlend-aasland deleted the sqlite-test-udf-str-with-null branch January 26, 2022 21:12

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 26, 2022

[3.10] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642).

f0fd0bd

(cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 30, 2022

erlend-aasland removed the needs backport to 3.9 label Jan 30, 2022

JelleZijlstra mentioned this pull request Feb 19, 2022

[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) #31030

Merged

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 25, 2022

[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…

b466671

…ythonGH-31030) (cherry picked from commit 3eb3b4f)

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 26, 2022

Adapt pythonGH-27642 tests

d3186be

miss-islington pushed a commit that referenced this pull request Mar 2, 2022

[3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030

3ea2a8f

) (GH-31586) (cherry picked from commit 3eb3b4f)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022

[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…

3743da6

…ythonGH-31030) (pythonGH-31586) (cherry picked from commit 3eb3b4f)

Uh oh!

Conversation

erlend-aasland commented Aug 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Aug 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka commented Aug 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Aug 12, 2021

Uh oh!

erlend-aasland commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Sep 15, 2021

Uh oh!

erlend-aasland commented Jan 26, 2022

Uh oh!

gvanrossum commented Jan 26, 2022

Uh oh!

miss-islington commented Jan 26, 2022

Uh oh!

miss-islington commented Jan 26, 2022

Uh oh!

miss-islington commented Jan 26, 2022

Uh oh!

JelleZijlstra commented Jan 26, 2022

Uh oh!

erlend-aasland commented Jan 26, 2022

Uh oh!

erlend-aasland commented Jan 26, 2022

Uh oh!

pablogsal commented Jan 26, 2022

Uh oh!

bedevere-bot commented Jan 30, 2022

Uh oh!

erlend-aasland commented Jan 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

erlend-aasland commented Aug 6, 2021 •

edited

Loading

erlend-aasland commented Sep 14, 2021 •

edited

Loading