bpo-44839: Raise more specific errors in sqlite3#27613
Merged
serhiy-storchaka merged 5 commits intopython:mainfrom Aug 6, 2021
Merged
bpo-44839: Raise more specific errors in sqlite3#27613serhiy-storchaka merged 5 commits intopython:mainfrom
serhiy-storchaka merged 5 commits intopython:mainfrom
Conversation
MemoryError raised in user-defined function will now preserve its type. OverflowError will now be converted to DataError. Previously both were converted to OperationalError.
serhiy-storchaka
force-pushed
the
sqlite-python-to-sqlite-errors
branch
from
99def7f to
d7fba66
Compare
erlend-aasland
requested changes
Aug 6, 2021
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM with minor adjustments. This is a nice refactoring. These changes will greatly simplify GH-27456. Thanks!
Misc/NEWS.d/next/Library/2021-08-05-14-59-39.bpo-44839.MURNL9.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
serhiy-storchaka
commented
Aug 6, 2021
Member
Author
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Thank you for your review. It is always good to have a second pair of eyes.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Jan 30, 2022
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between main (3.11) and older versions.
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 21, 2022
…1030) * [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642). (cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no> * Fix test_func_return_too_large_int GH-27613 (bpo 44839) was not backported, so exceptions differ between main (3.11) and older versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryError raised in user-defined function will now preserve
its type. OverflowError will now be converted to DataError.
Previously both were converted to OperationalError.
https://bugs.python.org/issue44839