-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
bpo-25008: Deprecate smtpd and point to aiosmtpd #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doc/library/smtpd.rst
Outdated
@@ -13,6 +13,13 @@ | |||
|
|||
This module offers several classes to implement SMTP (email) servers. | |||
|
|||
.. seealso:: | |||
|
|||
The `aiosmtpd <http://aiosmtpd.readthedocs.io/en/latest/>`_ package is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to drop the /en/latest/ part of the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM, thanks.
Yeah, it's time to say goodbye to asyncore :-( |
Hm... we don't have @Haypo I created an issue about replacing asyncore a while back: http://bugs.python.org/issue28533 |
I guess I'll do the cherry picks. I think they all need merge requests right? |
|
@Mariatta It also looks like 3.4 is not a protected branch. I think I can self-approve merges to that branch. |
Or maybe @dstufft was quicker than my browser. :) |
Fix ResourceWarning due to unclosed file resource.
We should probably also cherry pick this change into 3.4, 3.5, and 3.6 since those are the versions aiosmtpd are compatible with.