Skip to content

bpo-25008: Deprecate smtpd and point to aiosmtpd #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2017

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Feb 24, 2017

We should probably also cherry pick this change into 3.4, 3.5, and 3.6 since those are the versions aiosmtpd are compatible with.

@@ -13,6 +13,13 @@

This module offers several classes to implement SMTP (email) servers.

.. seealso::

The `aiosmtpd <http://aiosmtpd.readthedocs.io/en/latest/>`_ package is a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to drop the /en/latest/ part of the URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, thanks.

@vstinner vstinner merged commit fba79dc into python:master Feb 24, 2017
@vstinner
Copy link
Member

Yeah, it's time to say goodbye to asyncore :-(

@Mariatta
Copy link
Member

Hm... we don't have needs backport to 3.4 label..

@Haypo I created an issue about replacing asyncore a while back: http://bugs.python.org/issue28533

@warsaw warsaw deleted the bpo-25008 branch February 24, 2017 20:06
@warsaw
Copy link
Member Author

warsaw commented Feb 24, 2017

I guess I'll do the cherry picks. I think they all need merge requests right?

@Mariatta
Copy link
Member

I think they all need merge requests right?
Yes :)

warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
@warsaw
Copy link
Member Author

warsaw commented Feb 24, 2017

@Mariatta It also looks like 3.4 is not a protected branch. I think I can self-approve merges to that branch.

@warsaw
Copy link
Member Author

warsaw commented Feb 24, 2017

Or maybe @dstufft was quicker than my browser. :)

jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Fix ResourceWarning due to unclosed file resource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants