Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner #27210

Merged
merged 1 commit into from
Jul 17, 2021
Merged

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner #27210

merged 1 commit into from
Jul 17, 2021

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jul 17, 2021 •
edited by bedevere-bot
Loading

Fidget-Spinner
Fidget-Spinner approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though it feels weird seeing my handle there ;). We need to backport this to 3.10 and 3.9 too right? Otherwise backport PRs will ping Ivan.

@ambv
Copy link
Contributor Author

ambv commented Jul 17, 2021

Yes, this will indeed need backports.

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 17, 2021
@ambv
Copy link
Contributor Author

ambv commented Jul 17, 2021

Sorry, Ivan, address sanitizer refuses to let you go.

@ambv ambv merged commit 311ee83 into python:main Jul 17, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@ambv ambv deleted the remove-ivan branch July 17, 2021 09:21
@bedevere-bot
Copy link

GH-27212 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 17, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@ambv @miss-islington
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (pytho…
a9acc07 
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot
Copy link

GH-27213 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 17, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@ambv @miss-islington
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (pytho…
d7e0957 
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@Fidget-Spinner
Copy link
Member

Wow we managed to break ASAN 😉.

Thanks again for handling this Łukasz!

@ambv
Copy link
Contributor Author

ambv commented Jul 17, 2021

Naturally, it's literally my job.

@Fidget-Spinner
Copy link
Member

Haha, congrats on the position :).

ambv added a commit that referenced this pull request Jul 17, 2021
@miss-islington @ambv
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (GH-27210
8187033 
) (#27213)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jul 17, 2021
@miss-islington @ambv
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (GH-27210
e22e864 
) (#27212)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@isidentical
Copy link
Member

isidentical commented Jul 17, 2021 •
edited
Loading

Ah, I think this might not work for triagers :/

The people you choose as code owners must have write permissions for the repository.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners

@ambv
Copy link
Contributor Author

ambv commented Jul 17, 2021

There's a few ways we can fix this 😎

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ambv @bedevere-bot @miss-islington @Fidget-Spinner @isidentical @the-knights-who-say-ni