bpo-43770: PyObject_SetAttr() asserts that the type is ready #26880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyObject_SetAttr() now ensures that the object type is ready with an assertion. Moreover, it now only calls Py_DECREF(name) after raising the TypeError, rather than using a borrowed reference.
erlend-aasland
approved these changes
Jun 23, 2021
|
This change can be backward incompatible (for Python built in debug mode). Maybe an approach like PR #26881 is needed. The default implementation of tp_setattro is PyObject_GenericSetAttr (PyBaseObject_Type.tp_setattro), and it does make the type ready if it is not: https://bugs.python.org/issue43770 issue is when a static type uses tp_setattro=NULL and the PyObject_SetAttr() is called on a type which is not ready. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
I abandon this PR. I'm not convinced that it's safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyObject_SetAttr() now ensures that the object type is ready with an
assertion. Moreover, it now only calls Py_DECREF(name) after raising
the TypeError, rather than using a borrowed reference.
https://bugs.python.org/issue43770