bpo-30897: Add is_mount() to pathlib.Path #2669
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
Getting a Windows VM to play with the error. All suggestions welcome! |
vstinner
changed the title
|
I removed "bpo-30891: " from the title, since http://bugs.python.org/issue30891 is unrelated. |
cooperlees
changed the title
| @@ -1329,6 +1329,27 @@ def is_file(self): | |||
| # (see https://bitbucket.org/pitrou/pathlib/issue/12/) | |||
| return False | |||
|
|
|||
| def is_mount(self): | |||
| """ | |||
There was a problem hiding this comment.
would it be much easy to just return os.path.ismount(self) ?
There was a problem hiding this comment.
Easier, possibly. But I still think I'll hit my current issue with Windows. No like function in the library hits the 'os' module and I am pretty sure Python core developers would want this library standalone where possible.
|
I may need to rebase - that appveyor failure looks unrelated to me. |
* Add in is_mount() call to pathlib.Path similiar to os.path.ismount(path) * Add tests for is_mount()
|
Rebase got all checks to pass 💃 |
https://bugs.python.org/issue30897