Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34266: [pdb] handle ValueError from shlex.split() #26656

Merged
merged 5 commits into from
Jul 3, 2021
Merged

bpo-34266: [pdb] handle ValueError from shlex.split() #26656

merged 5 commits into from
Jul 3, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 10, 2021 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel changed the title handle ValueError from shlex.split() bpo-34266: handle ValueError from shlex.split() Jun 10, 2021
@iritkatriel
Copy link
Member Author

@blueyed Are you able to review?

@iritkatriel iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Jun 10, 2021
@iritkatriel @jacobtylerwalls
Update Misc/NEWS.d/next/Library/2021-06-10-21-53-46.bpo-34266.k3fxnm.rst
78715b4 
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@iritkatriel iritkatriel changed the title bpo-34266: handle ValueError from shlex.split() bpo-34266: [pdb] handle ValueError from shlex.split() Jun 14, 2021
@iritkatriel iritkatriel requested a review from terryjreedy June 14, 2021 12:11
@iritkatriel iritkatriel mentioned this pull request Jul 2, 2021
Closed
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2021
View reviewed changes
iritkatriel
iritkatriel commented Jul 3, 2021
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iritkatriel iritkatriel merged commit d968a63 into python:main Jul 3, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d968a638fcbf9030c999cfacd4c9bf0656e779c4 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 3, 2021
@bedevere-bot
Copy link

GH-27005 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2021
@iritkatriel @miss-islington
bpo-34266: [pdb] handle ValueError from shlex.split() (pythonGH-26656)
b0cb954 
(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jul 3, 2021
@iritkatriel
[3.10] bpo-34266: [pdb] handle ValueError from shlex.split() (pythonG…
49cf23b 
…H-26656)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-27006 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 3, 2021
iritkatriel added a commit that referenced this pull request Jul 3, 2021
@miss-islington @iritkatriel
bpo-34266: [pdb] handle ValueError from shlex.split() (GH-26656) (GH-…
21be6cb 
…27005)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Jul 3, 2021
@iritkatriel
[3.10] bpo-34266: [pdb] handle ValueError from shlex.split() (GH-26656)…
33022f9 
… (GH-27006)

(cherry picked from commit d968a63)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@iritkatriel iritkatriel deleted the bpo-34266 branch August 2, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@iritkatriel iritkatriel

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iritkatriel @miss-islington @bedevere-bot @serhiy-storchaka @jacobtylerwalls @the-knights-who-say-ni