Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44256: Do not expose _functools._list_elem_type. #26416

Merged
merged 1 commit into from
May 28, 2021
Merged

bpo-44256: Do not expose _functools._list_elem_type. #26416

merged 1 commit into from
May 28, 2021

Conversation

methane
Copy link
Member

@methane methane commented May 28, 2021 •
edited by bedevere-bot
Loading

It is for internal use only.

https://bugs.python.org/issue44256

@methane methane added the needs backport to 3.10 only security fixes label May 28, 2021
@methane methane requested a review from rhettinger as a code owner May 28, 2021 02:42
@methane methane requested a review from shihai1991 May 28, 2021 02:44
shihai1991
shihai1991 approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Inada for your PR.
_lru_list_elem doesn't exposed in python level. So I think this PR is acceptable.

@shihai1991 shihai1991 mentioned this pull request May 28, 2021
Merged
@methane methane merged commit 28be319 into python:main May 28, 2021
@methane methane deleted the bpo44256 branch May 28, 2021 05:09
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26418 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2021
@methane @miss-islington
bpo-44256: Do not expose _functools._list_elem_type (pythonGH-26416)
72d8c4e 
It is internal use only type.
(cherry picked from commit 28be319)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request May 28, 2021
@miss-islington @methane
bpo-44256: Do not expose _functools._list_elem_type (GH-26416)
35be1f3 
It is internal use only type.
(cherry picked from commit 28be319)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@sobolevn sobolevn mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991 shihai1991 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@methane @miss-islington @bedevere-bot @shihai1991 @erlend-aasland @the-knights-who-say-ni