Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. #25923

Merged
merged 2 commits into from
May 6, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 5, 2021

Co-authored-by: Gregory P. Smith greg@krypto.org
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
(cherry picked from commit 76cd81d)
Co-authored-by: Senthil Kumaran senthil@uthcode.com
Co-authored-by: Senthil Kumaran skumaran@gatech.edu
(cherry picked from commit 515a7bc)

Co-authored-by: Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com

https://bugs.python.org/issue43882

…newline and tabs. (pythonGH-25595) (pythonGH-25726)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 76cd81d)
Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
Co-authored-by: Senthil Kumaran <skumaran@gatech.edu>
(cherry picked from commit 515a7bc)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

@orsenthil: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@orsenthil: Status check is done, and it's a success ✅ .

@orsenthil orsenthil changed the title [3.7] [3.8] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) (GH-25726) [3.7] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. May 5, 2021
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.7 has failed when building commit f4dac7e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/430/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (f4dac7e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/430/builds/4

Failed tests:

  • test_socket

Failed subtests:

  • testSendFrame - test.test_socket.CANTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

403 tests OK.

1 test failed:
test_socket

12 tests skipped:
test_asdl_parser test_clinic test_devpoll test_gdb test_ioctl
test_kqueue test_msilib test_startfile test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_socket

Total duration: 26 min 12 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.7.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_socket.py", line 1866, in testSendFrame
    self.assertEqual(addr[0], self.interface)
AssertionError: 'v' != 'vcan0'
- v
+ vcan0

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.7 has failed when building commit f4dac7e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/351/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (f4dac7e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/351/builds/4

Failed tests:

  • test_socket

Failed subtests:

  • testSendFrame - test.test_socket.CANTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_tokenize: 3 min 57 sec
  • test_concurrent_futures: 3 min 41 sec
  • test_multiprocessing_spawn: 3 min 19 sec
  • test_lib2to3: 3 min 18 sec
  • test_tools: 2 min 31 sec
  • test_multiprocessing_forkserver: 1 min 57 sec
  • test_asyncio: 1 min 31 sec
  • test_multiprocessing_fork: 1 min 26 sec
  • test_io: 1 min 18 sec
  • test_gdb: 1 min 12 sec

1 test failed:
test_socket

9 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_socket

Total duration: 28 min 33 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.7.ware-gentoo-x86.nondebug/build/Lib/test/test_socket.py", line 1866, in testSendFrame
    self.assertEqual(addr[0], self.interface)
AssertionError: 'v' != 'vcan0'
- v
+ vcan0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants