Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44025: Clarify when '_' is a keyword. #25873

Merged
merged 2 commits into from
May 4, 2021
Merged

bpo-44025: Clarify when '_' is a keyword. #25873

merged 2 commits into from
May 4, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 4, 2021 •
edited by bedevere-bot
Loading

In match statements, in case patterns and nowhere else.

https://bugs.python.org/issue44025

@terryjreedy
bpo-44025: Clarify when '_' is a keyword.
1ebfb3d 
In match statements, in case patterns and nowhere else.
@terryjreedy terryjreedy added docs Documentation in the Doc dir needs backport to 3.10 only security fixes labels May 4, 2021
@terryjreedy @JelleZijlstra
Update Doc/reference/compound_stmts.rst
eac30fc 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@python python deleted a comment May 4, 2021
@ambv ambv merged commit 3b200b2 into python:main May 4, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @terryjreedy and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3b200b2aa648fcc8a2673871807c1463afe00195 3.10

@ambv ambv assigned terryjreedy and unassigned ambv May 4, 2021
@terryjreedy terryjreedy deleted the underscore branch May 4, 2021 11:14
@terryjreedy terryjreedy added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels May 4, 2021
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@terryjreedy @miss-islington
bpo-44025: Clarify when '_' is a keyword. (pythonGH-25873)
05067db 
In match statements, in case patterns and nowhere else.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 3b200b2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-25888 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 4, 2021
miss-islington added a commit that referenced this pull request May 4, 2021
@miss-islington @terryjreedy
bpo-44025: Clarify when '_' is a keyword. (GH-25873)
ae4f857 
In match statements, in case patterns and nowhere else.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 3b200b2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@terryjreedy terryjreedy mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees

@terryjreedy terryjreedy

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@terryjreedy @bedevere-bot @miss-islington @JelleZijlstra @Fidget-Spinner @ambv @the-knights-who-say-ni