Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43410: Fix crash in the parser when producing syntax errors when reading from stdin #24763

Merged
merged 1 commit into from
Mar 14, 2021
Merged

bpo-43410: Fix crash in the parser when producing syntax errors when reading from stdin #24763

merged 1 commit into from
Mar 14, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 5, 2021 •
edited by bedevere-bot
Loading

@pmp-p
Copy link
Contributor

pmp-p commented Mar 5, 2021 •
edited
Loading

does it occur only with stdin or in a more generic way with any input fd set to interactive ?

cf #22190

@pablogsal
Copy link
Member Author

does it occur only with stdin or in a more generic way with any input fd set to interactive ?

It happens for file descriptors that cannot be seeked back

@pablogsal pablogsal force-pushed the bpo-43410 branch 3 times, most recently from 5b6e474 to 18051b5 Compare March 5, 2021 19:34
@pablogsal pablogsal marked this pull request as draft March 5, 2021 19:35
@pablogsal pablogsal force-pushed the bpo-43410 branch 4 times, most recently from f753ac6 to 9d74397 Compare March 5, 2021 20:28
@pablogsal pablogsal marked this pull request as ready for review March 5, 2021 20:31
@pablogsal pablogsal force-pushed the bpo-43410 branch 3 times, most recently from 9d5c845 to e6e6b50 Compare March 5, 2021 22:09
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 5, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 9d150a7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 5, 2021
@pablogsal pablogsal merged commit cd8dcbc into python:master Mar 14, 2021
@pablogsal pablogsal deleted the bpo-43410 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @pmp-p @bedevere-bot @the-knights-who-say-ni