-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Remove duplicated operator.itemgetter example #24178
[doc] Remove duplicated operator.itemgetter example #24178
Conversation
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
* Remove duplicated itemgetter example * Add spaces (cherry picked from commit 743e2ba) Co-authored-by: Andre Delfino <adelfino@gmail.com>
GH-25646 is a backport of this pull request to the 3.9 branch. |
GH-25647 is a backport of this pull request to the 3.8 branch. |
Don't understand how we got here, but we have two examples for operator.itemgetter when used with dictionaries.
These are the PRs that added them:
#1280
#3431
Note that when each PR was created no example existed, yet they vary greatly on date.
Having two examples for the exact same use case is confusing. I'm preserving Raymond's example as it is clearer.
Also, fix markup by removing a blank line.