Skip to content

Conversation

@andresdelfino
Copy link
Contributor

Don't understand how we got here, but we have two examples for operator.itemgetter when used with dictionaries.

These are the PRs that added them:
#1280
#3431

Note that when each PR was created no example existed, yet they vary greatly on date.

Having two examples for the exact same use case is confusing. I'm preserving Raymond's example as it is clearer.

Also, fix markup by removing a blank line.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 21, 2021
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit 743e2ba into python:master Apr 27, 2021
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2021
* Remove duplicated itemgetter example
* Add spaces
(cherry picked from commit 743e2ba)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-25646 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-25647 is a backport of this pull request to the 3.8 branch.

orsenthil pushed a commit that referenced this pull request Apr 27, 2021
* Remove duplicated itemgetter example
* Add spaces
(cherry picked from commit 743e2ba)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
orsenthil pushed a commit that referenced this pull request Apr 27, 2021
* Remove duplicated itemgetter example
* Add spaces
(cherry picked from commit 743e2ba)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the duplicated_example_itemgetter branch April 27, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants