Skip to content

bpo-42851: [Enum] remove brittle __init_subclass__ support #24154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2021
Merged

bpo-42851: [Enum] remove brittle __init_subclass__ support #24154

merged 1 commit into from
Jan 7, 2021

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Jan 7, 2021 •
edited by bedevere-bot
Loading

Solution to support calls to __init_subclass__ with members defined is too brittle and breaks with certain mixins.

https://bugs.python.org/issue42851

@ethanfurman ethanfurman merged commit a581a86 into python:master Jan 7, 2021
@ethanfurman ethanfurman added the needs backport to 3.9 only security fixes label Jan 7, 2021
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a581a868d97f649aedf868a1d27865a10925c73a 3.9

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Jan 7, 2021
@ethanfurman
[3.9] bpo-42851: [Enum] remove brittle __init_subclass__ support (pyt…
2a0d01a 
…honGH-24154)

Solution to support calls to `__init_subclass__` with members defined is too brittle and breaks with certain mixins..
(cherry picked from commit a581a86)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 7, 2021
@bedevere-bot
Copy link

GH-24155 is a backport of this pull request to the 3.9 branch.

ethanfurman added a commit that referenced this pull request Jan 7, 2021
@ethanfurman
[3.9] bpo-42851: [Enum] remove brittle __init_subclass__ support (GH-…
9ab4dd4 
…24154) (GH-24155)

Solution to support calls to `__init_subclass__` with members defined is too brittle and breaks with certain mixins..
(cherry picked from commit a581a86)
@ethanfurman ethanfurman deleted the enum-remove_init_subclass branch January 7, 2021 23:30
@vstinner vstinner mentioned this pull request Jan 13, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ethanfurman @adorilson
bpo-42851: [Enum] remove brittle __init_subclass__ support (pythonGH-…
8e0800c 
…24154)

Solution to support calls to `__init_subclass__` with members defined is too brittle and breaks with certain mixins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ethanfurman ethanfurman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanfurman @miss-islington @bedevere-bot @the-knights-who-say-ni