Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42517: [Enum] do not convert private names into members #23722

Merged
merged 2 commits into from
Dec 10, 2020
Merged

bpo-42517: [Enum] do not convert private names into members #23722

merged 2 commits into from
Dec 10, 2020

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Dec 9, 2020 •
edited by bedevere-bot
Loading

@ethanfurman ethanfurman merged commit 7cf0aad into python:master Dec 10, 2020
@ethanfurman ethanfurman added the needs backport to 3.9 only security fixes label Dec 10, 2020
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@Mariatta Mariatta added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Dec 13, 2020
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 13, 2020
@bedevere-bot
Copy link

GH-23748 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2020
@ethanfurman @miss-islington
bpo-42517: [Enum] do not convert private names into members (pythonGH…
2324bdc 
…-23722)

private names, such as `_Color__hue` and `_Color__hue_` are now normal attributes, and do not become members nor raise exceptions
(cherry picked from commit 7cf0aad)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman pushed a commit that referenced this pull request Dec 14, 2020
@miss-islington
[3.9] bpo-42517: [Enum] deprecate private name members (GH-23722) (GH…
aba12b6 
…-23748)

private names will raise a DeprecationWarning; in 3.10 they will become normal attributes
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ethanfurman @adorilson
bpo-42517: [Enum] do not convert private names into members (pythonGH…
f2aa92d 
…-23722)

private names, such as `_Color__hue` and `_Color__hue_` are now normal attributes, and do not become members nor raise exceptions
@ethanfurman ethanfurman deleted the enum-private-non-member branch April 15, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethanfurman @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni