Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42151: don't set specified_attributes=1 in pure Python ElementTree #22987

Merged
merged 3 commits into from
Feb 24, 2021
Merged

bpo-42151: don't set specified_attributes=1 in pure Python ElementTree #22987

merged 3 commits into from
Feb 24, 2021

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Oct 26, 2020 •
edited
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@obfusk

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@scoder
Copy link
Contributor

scoder commented Oct 26, 2020

Thanks for your contribution. The patch looks good to me.
Please add a News entry and send in a signed CLA form.

@obfusk
Copy link
Contributor Author

obfusk commented Oct 26, 2020 •
edited
Loading

Please add a News entry

Done.

and send in a signed CLA form.

Already on its way :) Done.

@mattip
Copy link
Contributor

mattip commented Nov 20, 2020

Thanks @obfusk this solved the issue in PyPy.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@corona10 corona10 closed this Feb 23, 2021
@corona10 corona10 reopened this Feb 23, 2021
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@obfusk obfusk force-pushed the fix-issue-42151-elementree-default-values branch from accafb8 to f5f78d4 Compare February 24, 2021 01:36
@obfusk
bpo-42151: don't set specified_attributes=1 in pure Python ElementTree
f7a3bd1 
Make the pure Python implementation of xml.etree.ElementTree behave the
same as the C implementation (_elementree) with regards to default
attribute values (by not setting specified_attributes=1).
@obfusk
bpo-42151: add ElementTree test for default attribute values
1739e87
@obfusk obfusk force-pushed the fix-issue-42151-elementree-default-values branch from f5f78d4 to a38fea8 Compare February 24, 2021 01:45
@obfusk
Copy link
Contributor Author

obfusk commented Feb 24, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@obfusk obfusk force-pushed the fix-issue-42151-elementree-default-values branch from a38fea8 to a325328 Compare February 24, 2021 01:50
@corona10 corona10 merged commit 1f43340 into python:master Feb 24, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@obfusk @adorilson
bpo-42151: don't set specified_attributes=1 in pure Python ElementTree (
11657e5 
pythonGH-22987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@scoder scoder Awaiting requested review from scoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@obfusk @the-knights-who-say-ni @scoder @mattip @bedevere-bot @corona10 @serhiy-storchaka