bpo-30602: Fix lastarg in os.spawnve() #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eryksun: Would you mind to review this change please? |
eryksun
reviewed
Jun 20, 2017
| @@ -5266,7 +5266,7 @@ os_spawnve_impl(PyObject *module, int mode, path_t *path, PyObject *argv, | |||
| goto fail_1; | |||
| } | |||
| if (i == 0 && !argvlist[0][0]) { | |||
| lastarg = i; | |||
| lastarg = i + 1; | |||
There was a problem hiding this comment.
You can restore the initial value to Py_ssize_t lastarg = 0. But leaving it as -1 shouldn't be a problem since failures before this loop go to fail_0 instead of fail_1.
Fix a regression introduced by myself in the commit 526b226.
|
@eryksun: I made the requested change. Does it look good to you now? |
|
FYI I also tested manually that I didn't reintroduced a reference leak: "python -m test -R 3:3 test_os" succeed on Windows with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced by myself in the commit
526b226.