bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py #22619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gousaiyang for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @gousaiyang, I could not cleanly backport this to |
|
@gousaiyang Do you need additional help using cherry_picker? |
gousaiyang
added a commit
to gousaiyang/cpython
that referenced
this pull request
Oct 9, 2020
…py (pythonGH-22619) There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names. Automerge-Triggered-By: @gvanrossum. (cherry picked from commit b2c0a43) Co-authored-by: Saiyang Gou <gousaiyang@163.com>
|
GH-22624 is a backport of this pull request to the 3.9 branch. |
gvanrossum
pushed a commit
that referenced
this pull request
Oct 12, 2020
…py (GH-22619) (#22624) There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names. Automerge-Triggered-By: @gvanrossum. (cherry picked from commit b2c0a43) Co-authored-by: Saiyang Gou <gousaiyang@163.com>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…thonGH-22619) There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names. Automerge-Triggered-By: @gvanrossum
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…thonGH-22619) There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names. Automerge-Triggered-By: @gvanrossum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different
SimpleQueuetypes imported (frommultiprocessing.queuesandqueue) inLib/test/test_genericalias.py, the second one shadowing the first one, making the first one not actually tested. Fix by using different names.https://bugs.python.org/issue39481
Automerge-Triggered-By: @gvanrossum