bpo-41873: Add vectorcall for float() #22432

sweeneyde · 2020-09-28T08:55:33Z

https://bugs.python.org/issue41873

corona10

Your patch will cause the crash

Type "help", "copyright", "credits" or "license" for more information.
>>> float()
[1]    44448 segmentation fault  ./python.exe

bedevere-bot · 2020-09-28T09:04:28Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

corona10

~~Please add the test case that I pointed out~~ -> the case is already existed.

corona10 · 2020-09-28T09:09:56Z

Objects/floatobject.c

+        return NULL;
+    }
+
+    return float_new_impl((PyTypeObject *)type, args[0]);


Suggested change

return float_new_impl((PyTypeObject *)type, args[0]);

PyObject *x = NULL;

if (nargs > 0) {

x = args[0];

} else {

x = _PyLong_Zero;

}

return float_new_impl((PyTypeObject *)type, x);

… into float_vectorcall

sweeneyde · 2020-09-28T09:37:59Z

I have made the requested changes; please review again.

@corona10 I didn't see any occurrences of float() in test_float.py, so I added a test. Where are you saying the test already exists?

bedevere-bot · 2020-09-28T09:38:03Z

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10 · 2020-09-28T09:51:00Z

I didn't see any occurrences of float() in test_float.py

https://github.com/python/cpython/pull/22432/checks?check_run_id=1175574849

There was already a crash on your PR on CI phase.
So I guess that there is already in, but it looks like good to add the case on test_float.py

corona10

I am lgtm about the changes,
but let's wait for other core devs opinions about adding vectorcall for float type.

corona10 · 2020-09-28T16:23:42Z

@markshannon

This PR is same case from #22427

Do you think that the vectorcall is good enough to apply for float() call also from the maintenance cost view?

vstinner

LGTM. IMHO removing 27.5 ns on 79 ns (1.5x faster) per float(obj) is worth it.

I let @corona10 merge the PR ;-)

bedevere-bot · 2020-09-29T01:26:50Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x has failed when building commit e8acc35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/567/builds/758) and take a look at the build logs.
Check if the failure is related to this commit (e8acc35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/567/builds/758

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

408 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 53 sec
test_peg_generator: 2 min 52 sec
test_gdb: 1 min 36 sec
test_multiprocessing_spawn: 1 min 13 sec
test_multiprocessing_forkserver: 1 min 1 sec
test_multiprocessing_fork: 53.5 sec
test_asyncio: 49.1 sec
test_signal: 47.1 sec
test_tokenize: 34.3 sec
test_io: 34.0 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 5 min 33 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...

Add vectorcall for float()

d14c925

the-knights-who-say-ni added the CLA signed label Sep 28, 2020

bedevere-bot added the awaiting review label Sep 28, 2020

📜🤖 Added by blurb_it.

69e31c6

corona10 requested changes Sep 28, 2020

View reviewed changes

bedevere-bot removed the awaiting review label Sep 28, 2020

bedevere-bot added the awaiting changes label Sep 28, 2020

corona10 reviewed Sep 28, 2020

View reviewed changes

corona10 requested a review from vstinner September 28, 2020 09:11

sweeneyde added 2 commits September 28, 2020 05:24

Fix zero-argument case

7c93858

Merge branch 'float_vectorcall' of https://github.com/sweeneyde/cpython…

927b758

… into float_vectorcall

bedevere-bot added awaiting change review and removed awaiting changes labels Sep 28, 2020

bedevere-bot requested a review from corona10 September 28, 2020 09:38

corona10 approved these changes Sep 28, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Sep 28, 2020

corona10 requested a review from markshannon September 28, 2020 16:20

vstinner approved these changes Sep 28, 2020

View reviewed changes

corona10 merged commit e8acc35 into python:master Sep 29, 2020

bedevere-bot removed the awaiting merge label Sep 29, 2020

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41873: Add vectorcall for float() (pythonGH-22432)

305f95c

sweeneyde deleted the float_vectorcall branch January 25, 2022 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-41873: Add vectorcall for float() #22432

bpo-41873: Add vectorcall for float() #22432

sweeneyde commented Sep 28, 2020 •

edited by bedevere-bot

Loading

corona10 left a comment

bedevere-bot commented Sep 28, 2020

corona10 left a comment •

edited

Loading

corona10 Sep 28, 2020 •

edited

Loading

sweeneyde commented Sep 28, 2020

bedevere-bot commented Sep 28, 2020

corona10 commented Sep 28, 2020

corona10 left a comment

corona10 commented Sep 28, 2020 •

edited

Loading

vstinner left a comment

bedevere-bot commented Sep 29, 2020

-    return float_new_impl((PyTypeObject *)type, args[0]);
+    PyObject *x = NULL;
+    if (nargs > 0) {
+        x = args[0];
+    } else {
+        x = _PyLong_Zero;
+    }
+    return float_new_impl((PyTypeObject *)type, x);

bpo-41873: Add vectorcall for float() #22432

bpo-41873: Add vectorcall for float() #22432

Conversation

sweeneyde commented Sep 28, 2020 • edited by bedevere-bot Loading

corona10 left a comment

Choose a reason for hiding this comment

bedevere-bot commented Sep 28, 2020

corona10 left a comment • edited Loading

Choose a reason for hiding this comment

corona10 Sep 28, 2020 • edited Loading

Choose a reason for hiding this comment

sweeneyde commented Sep 28, 2020

bedevere-bot commented Sep 28, 2020

corona10 commented Sep 28, 2020

corona10 left a comment

Choose a reason for hiding this comment

corona10 commented Sep 28, 2020 • edited Loading

vstinner left a comment

Choose a reason for hiding this comment

bedevere-bot commented Sep 29, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

sweeneyde commented Sep 28, 2020 •

edited by bedevere-bot

Loading

corona10 left a comment •

edited

Loading

corona10 Sep 28, 2020 •

edited

Loading

corona10 commented Sep 28, 2020 •

edited

Loading