Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41672: Fix type mismatches in imaplib docs #22207

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

norbertcyran
Copy link
Contributor

@norbertcyran norbertcyran commented Sep 11, 2020

Some places documented return types as strings since Python 2.
This commit replaces invalid string occurrences with bytes.

https://bugs.python.org/issue41672

Some places documented return types as strings since Python 2.
This commit replaces invalid string occurrences with bytes.
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks for the contribution

@corona10 corona10 merged commit c753306 into python:master Sep 12, 2020
@miss-islington
Copy link
Contributor

Thanks @norbertcyran for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
(cherry picked from commit c753306)

Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com>
@bedevere-bot
Copy link

GH-22217 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 12, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
(cherry picked from commit c753306)

Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com>
@bedevere-bot
Copy link

GH-22218 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2020
(cherry picked from commit c753306)

Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com>
corona10 pushed a commit that referenced this pull request Sep 12, 2020
(cherry picked from commit c753306)

Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com>

Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants