bpo-41700: Skip test if the locale is not supported #22081

corona10 · 2020-09-03T15:42:00Z

https://bugs.python.org/issue41700

vstinner

Your PR doesn't fix the issue, see https://bugs.python.org/issue41700#msg376320 to reproduce the issue.

Lib/test/test_c_locale_coercion.py

corona10

@vstinner
Thanks, Victor
I fixed the wrong point
I 've updated the PR and it works well on the reproducing scenario

vstinner

LGTM. I tested manually that the PR fix https://bugs.python.org/issue41700.

It should be backport to 3.9, and maybe also to 3.8, no?

corona10 · 2020-09-04T08:47:14Z

It should be backport to 3.9, and maybe also to 3.8, no?

I will add the label! Thanks!

miss-islington · 2020-09-04T08:47:43Z

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2020-09-04T08:48:01Z

GH-22085 is a backport of this pull request to the 3.9 branch.

(cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot · 2020-09-04T08:48:10Z

GH-22086 is a backport of this pull request to the 3.8 branch.

) (cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot · 2020-09-04T10:40:52Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.9 has failed when building commit 8f13ff9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/508/builds/262) and take a look at the build logs.
Check if the failure is related to this commit (8f13ff9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/508/builds/262

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

test_peg_generator: 5 min 9 sec
test_concurrent_futures: 3 min 9 sec
test_gdb: 3 min 1 sec
test_multiprocessing_spawn: 1 min 41 sec
test_tokenize: 1 min 39 sec
test_multiprocessing_forkserver: 1 min 21 sec
test_unparse: 1 min 6 sec
test_asyncio: 57.3 sec
test_multiprocessing_fork: 55.3 sec
test_lib2to3: 53.5 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 7 min

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 678, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 729, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

…lots1 * origin/master: (63 commits) bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098) bpo-38585: Remove references to defusedexpat (pythonGH-22095) bpo-41721: Add xlc options (pythonGH-22096) bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025) bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999) bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087) bpo-41700: Skip test if the locale is not supported (pythonGH-22081) [doc] Update documentation on logging optimization. (pythonGH-22075) Fix 'gather' rules in the python parser generator (pythonGH-22021) bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077) [doc] Fix a typo in the graphlib docs (python#22030) bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049) bpo-39883: Use BSD0 license for code in docs (pythonGH-17635) bpo-39010: Improve test shutdown (python#22066) bpo-41696: Fix handling of debug mode in asyncio.run (python#22069) bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053) closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058) Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047) bpo-41675: Modernize siginterrupt calls (pythonGH-22028) bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062) ...

corona10 requested a review from vstinner September 3, 2020 15:42

the-knights-who-say-ni added the CLA signed label Sep 3, 2020

bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Sep 3, 2020

corona10 added skip issue skip news and removed awaiting core review tests Tests in the Lib/test dir skip issue labels Sep 3, 2020

corona10 force-pushed the bpo-41700 branch from d39b88c to bb63897 Compare September 3, 2020 15:45

vstinner reviewed Sep 3, 2020

View reviewed changes

Lib/test/test_c_locale_coercion.py Outdated Show resolved Hide resolved

bpo-41700: Skip test if the locale is not supported

84247cc

corona10 force-pushed the bpo-41700 branch from bb63897 to 84247cc Compare September 4, 2020 02:37

corona10 requested a review from vstinner September 4, 2020 04:11

corona10 commented Sep 4, 2020

View reviewed changes

vstinner approved these changes Sep 4, 2020

View reviewed changes

bedevere-bot added the awaiting merge label Sep 4, 2020

corona10 added needs backport to 3.8 needs backport to 3.9 only security fixes labels Sep 4, 2020

corona10 merged commit 54a66ad into python:master Sep 4, 2020

bedevere-bot removed the awaiting merge label Sep 4, 2020

bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 4, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020

bpo-41700: Skip test if the locale is not supported (pythonGH-22081)

ec80042

(cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020

bpo-41700: Skip test if the locale is not supported (pythonGH-22081)

2d5631d

(cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot removed the needs backport to 3.8 label Sep 4, 2020

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41700: Skip test if the locale is not supported (pythonGH-22081)

13d3a0f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-41700: Skip test if the locale is not supported #22081

bpo-41700: Skip test if the locale is not supported #22081

corona10 commented Sep 3, 2020 •

edited by bedevere-bot

Loading

vstinner left a comment

corona10 left a comment •

edited

Loading

vstinner left a comment

corona10 commented Sep 4, 2020

miss-islington commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

bpo-41700: Skip test if the locale is not supported #22081

bpo-41700: Skip test if the locale is not supported #22081

Conversation

corona10 commented Sep 3, 2020 • edited by bedevere-bot Loading

vstinner left a comment

Choose a reason for hiding this comment

corona10 left a comment • edited Loading

Choose a reason for hiding this comment

vstinner left a comment

Choose a reason for hiding this comment

corona10 commented Sep 4, 2020

miss-islington commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

bedevere-bot commented Sep 4, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

corona10 commented Sep 3, 2020 •

edited by bedevere-bot

Loading

corona10 left a comment •

edited

Loading