Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fix a typo in the graphlib docs #22030

Merged
merged 2 commits into from
Sep 3, 2020
Merged

[doc] Fix a typo in the graphlib docs #22030

merged 2 commits into from
Sep 3, 2020

Conversation

mariosasko
Copy link
Contributor

This PR fixes a typo in the docs of a TopologicalSorter.is_active.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mariosasko

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 31, 2020
tirkarthi
tirkarthi approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi requested a review from pablogsal September 1, 2020 13:42
@tirkarthi
Copy link
Member

Please update your branch with the latest master branch since it has changes that will help docs build error.

@pablogsal pablogsal self-assigned this Sep 1, 2020
@mariosasko
Copy link
Contributor Author

Please update your branch with the latest master branch since it has changes that will help docs build error.

Did it.

@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Sep 3, 2020
@pablogsal pablogsal merged commit 8516060 into python:master Sep 3, 2020
@bedevere-bot
Copy link

@pablogsal: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @mariosasko for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2020
@mariosasko @miss-islington
[doc] Fix a typo in the graphlib docs (pythonGH-22030)
a0b69c8 
(cherry picked from commit 8516060)

Co-authored-by: Mario Šaško <mariosasko777@gmail.com>
@bedevere-bot
Copy link

GH-22076 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 3, 2020
@pablogsal
Copy link
Member

Thanks @mariosasko for the PR! 🎉

miss-islington added a commit that referenced this pull request Sep 4, 2020
@miss-islington @mariosasko
[3.9] [doc] Fix a typo in the graphlib docs (GH-22030) (GH-22076)
672d8b9 
(cherry picked from commit 8516060)


Co-authored-by: Mario Šaško <mariosasko777@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 5, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…
7537c86 
…lots1

* origin/master: (63 commits)
  bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098)
  bpo-38585: Remove references to defusedexpat (pythonGH-22095)
  bpo-41721: Add xlc options (pythonGH-22096)
  bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025)
  bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999)
  bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087)
  bpo-41700: Skip test if the locale is not supported (pythonGH-22081)
  [doc] Update documentation on logging optimization. (pythonGH-22075)
  Fix 'gather' rules in the python parser generator (pythonGH-22021)
  bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077)
  [doc] Fix a typo in the graphlib docs (python#22030)
  bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049)
  bpo-39883: Use BSD0 license for code in docs (pythonGH-17635)
  bpo-39010: Improve test shutdown (python#22066)
  bpo-41696: Fix handling of debug mode in asyncio.run (python#22069)
  bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053)
  closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058)
  Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047)
  bpo-41675: Modernize siginterrupt calls (pythonGH-22028)
  bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@mariosasko
[doc] Fix a typo in the graphlib docs (python#22030)
686da96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@pablogsal pablogsal

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mariosasko @the-knights-who-say-ni @tirkarthi @bedevere-bot @miss-islington @pablogsal