bpo-1635741: port sha3 module to multi-phase init #21855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koubaa
force-pushed
the
bpo-1635741-sha3
branch
from
eed1ea7 to
f91e1ae
Compare
Contributor
Author
|
@vstinner @shihai1991 please review |
shihai1991
reviewed
Aug 22, 2020
vstinner
reviewed
Aug 25, 2020
Misc/NEWS.d/next/Core and Builtins/2020-08-13-07-19-21.bpo-1653741.fubBkb.rst
Outdated
Show resolved
Hide resolved
vstinner
reviewed
Aug 26, 2020
vstinner
reviewed
Aug 27, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
@corona10 @shihai1991: The change is mostly LGTM (remaining comments are mostly about minor coding style issues), but I would prefer a second review. Would you mind to review this PR?
shihai1991
reviewed
Aug 27, 2020
vstinner
reviewed
Aug 28, 2020
vstinner
reviewed
Aug 29, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Sep 1, 2020
Misc/NEWS.d/next/Core and Builtins/2020-08-13-07-19-21.bpo-1653741.fubBkb.rst
Outdated
Show resolved
Hide resolved
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Port the _sha3 extension module to multi-phase init (PEP 489). Convert static types to heap types.
Member
|
Please respect the code ownership / expert index and do not merge any PRs without approval of a domain expert. This PR introduced a possible security issue. |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Apr 17, 2021
Commit 93d50a6 / pythonGH-21855 changed the order of variable definitions, which introduced a potential invalid free bug. Py_buffer object is now initialized earlier and the result of Keccak initialize is verified. Co-authored-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Christian Heimes <christian@python.org>
tiran
added a commit
that referenced
this pull request
Apr 18, 2021
Commit 93d50a6 / GH-21855 changed the order of variable definitions, which introduced a potential invalid free bug. Py_buffer object is now initialized earlier and the result of Keccak initialize is verified. Co-authored-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Christian Heimes <christian@python.org> Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741