Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findAllAdverbs #21420

Merged
merged 2 commits into from
Oct 9, 2021
Merged

findAllAdverbs #21420

merged 2 commits into from
Oct 9, 2021

Conversation

RymCh
Copy link
Contributor

@RymCh RymCh commented Jul 9, 2020

re.findall(r"\w+ly", text) does not find all adverbs in a sentence, it finds words that contain ly (not ending with ly) :
if text= 'andlying clearly', output: [andly, clearly]
which is wrong!
the right way to do this is re.findall(r"\b\w+ly\b",text)
output= clearly!

re.findall(r"\w+ly", text) does not find all adverbs in a sentence, it finds words that contain ly (not ending with ly) :
if text= 'andlying clearly', output: [andly, clearly]
which is wrong! 
the right way to do this is re.findall(r"\b\w+ly\b",text)
output= clearly!
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@RymCh

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 9, 2020
@csabella
Copy link
Contributor

@RymCh, please sign the CLA and please also take a look at the code review by Serhiy. Thank you!

@miss-islington
Copy link
Contributor

Thanks @RymCh for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-28839 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 9, 2021
@bedevere-bot
Copy link

GH-28840 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2021
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit dbd62e7)

Co-authored-by: Rim Chatti <chattiriim@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2021
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit dbd62e7)

Co-authored-by: Rim Chatti <chattiriim@gmail.com>
Mariatta pushed a commit that referenced this pull request Oct 10, 2021
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit dbd62e7)

Co-authored-by: Rim Chatti <chattiriim@gmail.com>
Mariatta pushed a commit that referenced this pull request Oct 10, 2021
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit dbd62e7)

Co-authored-by: Rim Chatti <chattiriim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants