Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitattribute -> .gitattributes #213

Merged
merged 1 commit into from
Feb 21, 2017
Merged

.gitattribute -> .gitattributes #213

merged 1 commit into from
Feb 21, 2017

Conversation

methane
Copy link
Member

@methane methane commented Feb 21, 2017

I'm sorry, it should be .gitattribute"s"

https://git-scm.com/docs/gitattributes

berkerpeksag
berkerpeksag approved these changes Feb 21, 2017
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So apparently I shouldn't review any pull request when I was awake for more than 20 hours :)

@methane methane merged commit 2c700af into python:master Feb 21, 2017
@methane methane deleted the news-merge branch February 21, 2017 09:39
@methane
Copy link
Member Author

methane commented Feb 21, 2017

Hm, it doesn't affects pull request already opened.
#51 reports conflict on Misc/NEWS yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methane @berkerpeksag @the-knights-who-say-ni