bpo-41144: Fix IDLE open module error #21182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the abstract method requires the "name" argument, we catch the raised TypeError
terryjreedy
requested changes
Jun 27, 2020
|
I am going to manually verify fix and try to add a test that now fails. I could have you do it, but I am in a mood to commit this tonight. |
terryjreedy
added
needs backport to 3.8
needs backport to 3.9
terryjreedy
approved these changes
Jun 28, 2020
|
Thanks @E-Paine for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
@terryjreedy: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2020
Could not open os.path. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 8ab77c6) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
|
GH-21193 is a backport of this pull request to the 3.9 branch. |
|
GH-21194 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2020
Could not open os.path. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 8ab77c6) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jun 28, 2020
miss-islington
added a commit
that referenced
this pull request
Jun 28, 2020
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
Could not open os.path. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
Could not open os.path. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41144