Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36346: Make unicodeobject.h C89 compatible #20934

Merged
merged 1 commit into from
Jun 17, 2020
Merged

bpo-36346: Make unicodeobject.h C89 compatible #20934

merged 1 commit into from
Jun 17, 2020

Conversation

methane
Copy link
Member

@methane methane commented Jun 17, 2020 •
edited by miss-islington
Loading

@methane methane added type-bug An unexpected behavior, bug, or error skip news labels Jun 17, 2020
@methane methane requested a review from vstinner June 17, 2020 12:31
@methane methane added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed CLA signed labels Jun 17, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @methane for commit 8b54cb7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
vstinner
vstinner approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".

Include/cpython/unicodeobject.h
@@ -53,7 +53,8 @@ Py_UNICODE_COPY(Py_UNICODE *target, const Py_UNICODE *source, Py_ssize_t length)

Py_DEPRECATED(3.3) static inline void
Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) {
for (Py_ssize_t i = 0; i < length; i++) {
Py_ssize_t i;
for (i = 0; i < length; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.

@methane methane changed the title bpo-36346: Fix buildbots bpo-36346: Make unicodeobject.h C89 compatible Jun 17, 2020
@methane methane merged commit 8e34e92 into python:master Jun 17, 2020
@methane methane deleted the fix-buildbot branch June 17, 2020 14:43
methane added a commit to methane/cpython that referenced this pull request Jun 17, 2020
@methane
bpo-36346: Make unicodeobject.h C89 compatible (pythonGH-20934)
5fc4e4b
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@methane @arun-mani-j
bpo-36346: Make unicodeobject.h C89 compatible (pythonGH-20934)
946e605
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @bedevere-bot @vstinner @the-knights-who-say-ni