Use Travis to make sure all generated files are up to date #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zware, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @berkerpeksag and @dstufft to be potential reviewers. |
ncoghlan
approved these changes
Jun 11, 2017
There was a problem hiding this comment.
LGTM, and I see from the commit history that you've checked to ensure it actually fails CI when provoked :)
Another useful thing this will check is cherry-picked regenerated files - those where the changes have been brought in from master (e.g. by cherry_pick.py), rather than the regeneration being run on the target branch.
|
Thanks, Nick! As @serhiy-storchaka already gave approval of at least the approach on IRC, I'll go ahead and merge. |
zware
added a commit
to zware/cpython
that referenced
this pull request
Jun 11, 2017
…honGH-2080) (cherry picked from commit 0afbabe)
zware
added a commit
to zware/cpython
that referenced
this pull request
Jun 11, 2017
…honGH-2080) (cherry picked from commit 0afbabe)
zware
added a commit
that referenced
this pull request
Jun 11, 2017
zware
added a commit
that referenced
this pull request
Jun 11, 2017
zware
added a commit
to zware/cpython
that referenced
this pull request
Jun 11, 2017
zware
added a commit
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this works as expected, it should effectively address python/core-workflow#118, unless we really want it as a separate check.